<html>
<head><meta charset="utf-8"><title>Meeting 2021-04-06 · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html">Meeting 2021-04-06</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="233301329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233301329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233301329">(Apr 06 2021 at 11:14)</a>:</h4>
<p>Meeting <time datetime="2021-04-06T15:00:00Z">2021-04-06T17:00:00+02:00</time> </p>
<p>Agenda:</p>
<ul>
<li>Triage</li>
<li>More lintcheck todos <a href="https://github.com/rust-lang/rust-clippy/issues/6710">rust-clippy#6710</a> (<code>I-nominated</code>)</li>
</ul>
<p>Sorry for posting this late, I stayed the Easter weekend away from my computer. I still have to catch up with my GH notifications, so if there is some important thing to discuss that I missed, please let me know.</p>



<a name="233331547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233331547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233331547">(Apr 06 2021 at 14:51)</a>:</h4>
<p>Meeting in t-10min</p>



<a name="233333079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233333079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233333079">(Apr 06 2021 at 15:00)</a>:</h4>
<p>o/</p>



<a name="233333554"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233333554" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233333554">(Apr 06 2021 at 15:01)</a>:</h4>
<p>Meeting time! <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="233333905"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233333905" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233333905">(Apr 06 2021 at 15:02)</a>:</h4>
<p>Are there any interesting issues before the sync on Thursday?</p>



<a name="233334272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233334272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233334272">(Apr 06 2021 at 15:03)</a>:</h4>
<p>I think there's some upstream breakage incoming</p>



<a name="233334310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233334310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233334310">(Apr 06 2021 at 15:03)</a>:</h4>
<p>but no</p>



<a name="233334333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233334333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233334333">(Apr 06 2021 at 15:03)</a>:</h4>
<p>I don't think so and none have been labeled as such</p>



<a name="233334349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233334349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233334349">(Apr 06 2021 at 15:03)</a>:</h4>
<p>I's like this: <a href="https://github.com/rust-lang/rust-clippy/issues/6931">rust-clippy#6931</a> to get merged before the sync, since it will make the sync very painful.</p>



<a name="233335149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233335149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233335149">(Apr 06 2021 at 15:05)</a>:</h4>
<p>not related to the sync but there is discussion about uplifting a clippy lint into rustc, I don't think the clippy team was pinged on that one yet?<br>
<a href="https://github.com/rust-lang/rust/issues/83899">https://github.com/rust-lang/rust/issues/83899</a></p>



<a name="233335158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233335158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233335158">(Apr 06 2021 at 15:05)</a>:</h4>
<p>2 more  things that kinda fit in "triage":</p>
<ol>
<li><a href="https://github.com/rust-lang/clippy/issues/1234">clippy#1234</a> doesn't seem to work anymore and we have to use <a href="https://github.com/rust-lang/rust-clippy/issues/1234">rust-clippy#1234</a> to link things.</li>
<li><span class="user-mention" data-user-id="217864">@matthiaskrgr</span> added <code>I-nominated</code> label. If you want to discuss an issue/PR, just label it with that and I'll add it to the agenda.</li>
</ol>



<a name="233335412"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233335412" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233335412">(Apr 06 2021 at 15:06)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217864">matthiaskrgr</span> <a href="#narrow/stream/257328-clippy/topic/Meeting.202021-04-06/near/233335149">said</a>:</p>
<blockquote>
<p>not related to the sync but there is discussion about uplifting a clippy lint into rustc, I don't think the clippy team was pinged on that one yet?<br>
<a href="https://github.com/rust-lang/rust/issues/83899">https://github.com/rust-lang/rust/issues/83899</a></p>
</blockquote>
<p>Ah good to know, I'll take a look after the meeting.</p>



<a name="233335581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233335581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233335581">(Apr 06 2021 at 15:06)</a>:</h4>
<p>I don't have anything else regarding triage <span class="user-mention" data-user-id="261224">@triagebot</span> end-topic</p>



<a name="233335587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233335587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233335587">(Apr 06 2021 at 15:06)</a>:</h4>
<p>Does anyone have something to add on the current topic?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if not.</p>



<a name="233335662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233335662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233335662">(Apr 06 2021 at 15:06)</a>:</h4>
<p>I'm not sure what the usual process about  uplifting is, whether the uplift-pr should also remove the lint from clippy at the same time etc...</p>



<a name="233335913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233335913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233335913">(Apr 06 2021 at 15:07)</a>:</h4>
<p>Yes it should. But we don't have any documentation or tooling to do that. So most of the time someone from Clippy has to provide the patch for deprecating the Clippy lint directly.</p>



<a name="233336237"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336237" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336237">(Apr 06 2021 at 15:08)</a>:</h4>
<p>Ok next up: <span class="user-mention" data-user-id="217864">@matthiaskrgr</span> you nominated the lintcheck tracking issue.</p>



<a name="233336437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336437">(Apr 06 2021 at 15:09)</a>:</h4>
<p>Yes, I have lintcheck run every 12 hours on ci now, on around ~500-600 crates, logs are pushed into the projects repo</p>



<a name="233336482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336482">(Apr 06 2021 at 15:09)</a>:</h4>
<p><a href="https://github.com/matthiaskrgr/clippy-lintcheck">https://github.com/matthiaskrgr/clippy-lintcheck</a></p>



<a name="233336620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336620">(Apr 06 2021 at 15:10)</a>:</h4>
<p>Ah cool. How long does one CI run take?</p>



<a name="233336670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336670">(Apr 06 2021 at 15:10)</a>:</h4>
<p>I think it was around 40 minutes? let me check...</p>



<a name="233336772"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336772" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336772">(Apr 06 2021 at 15:10)</a>:</h4>
<p>yeah, 45-35 minutes</p>



<a name="233336911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336911">(Apr 06 2021 at 15:11)</a>:</h4>
<p>That's not too bad.</p>



<a name="233336965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336965">(Apr 06 2021 at 15:11)</a>:</h4>
<p><span class="user-mention" data-user-id="217864">@matthiaskrgr</span> the process is basically "let them take the lint, and once it's in, we deprecate ours"</p>



<a name="233336998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233336998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233336998">(Apr 06 2021 at 15:11)</a>:</h4>
<p>but that's also the sequential mode. We might be able to gain a bit more by using -j2 or so ..</p>



<a name="233337201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337201">(Apr 06 2021 at 15:12)</a>:</h4>
<p><span class="user-mention" data-user-id="132040">@Manish Goregaokar</span>  ah so we'll just deprecate the lint on the corresponding sync then..? cool. :)</p>



<a name="233337215"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337215" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337215">(Apr 06 2021 at 15:12)</a>:</h4>
<p>Should we move this repo to the rust-lang org so it's a bit more visible and all of the Clippy team can work on it?</p>



<a name="233337387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337387">(Apr 06 2021 at 15:13)</a>:</h4>
<p>I prefer to deprecate it in the same PR. Otherwise the sync gets messy.</p>



<a name="233337388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337388">(Apr 06 2021 at 15:13)</a>:</h4>
<p>Mmh, I would not want it to eat away rustcs valuable ci time .. <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="233337520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337520">(Apr 06 2021 at 15:13)</a>:</h4>
<p>I think once a week should be enough to run it?</p>



<a name="233337583"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337583" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337583">(Apr 06 2021 at 15:14)</a>:</h4>
<p>Also its just one runner I guess?</p>



<a name="233337652"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337652" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337652">(Apr 06 2021 at 15:14)</a>:</h4>
<p>Yeah only one runner, right.</p>



<a name="233337787"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233337787" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233337787">(Apr 06 2021 at 15:14)</a>:</h4>
<p>I kinda like running it a lot because it makes bisecting bugs so much easier</p>



<a name="233338020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233338020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233338020">(Apr 06 2021 at 15:15)</a>:</h4>
<p>I can probably still optimize to run it only if there is a new clippy commit :)</p>



<a name="233338156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233338156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233338156">(Apr 06 2021 at 15:16)</a>:</h4>
<p>Yeah, but someone will have to look at the changed logs. And at least I can't do this more than once a week.</p>



<a name="233338404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233338404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233338404">(Apr 06 2021 at 15:16)</a>:</h4>
<p>Running it on Clippy changes also seems reasonable. But then only once a day?</p>



<a name="233338424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233338424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233338424">(Apr 06 2021 at 15:16)</a>:</h4>
<p>I don't check every single new message, but I usually glance over it to see if there is something that I find suspicious</p>



<a name="233338781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233338781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233338781">(Apr 06 2021 at 15:18)</a>:</h4>
<p>Yeah, just looked at one of the update commits. With the stats at the end you can figure out pretty easily if something sus is going on.</p>



<a name="233338901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233338901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233338901">(Apr 06 2021 at 15:19)</a>:</h4>
<p>I would like to have this in the rust-lang org anyway. So should we talk to infra if that'd be ok and how often we'd be allowed to run it?</p>



<a name="233339212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339212">(Apr 06 2021 at 15:21)</a>:</h4>
<p><span class="user-mention" data-user-id="217864">@matthiaskrgr</span> Do you want to contact infra? You put more time into this, so probably can better argue why running it more often is better.</p>



<a name="233339271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339271">(Apr 06 2021 at 15:21)</a>:</h4>
<p>by contacting infra, I mean open a zulip thread :)</p>



<a name="233339278"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339278" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339278">(Apr 06 2021 at 15:21)</a>:</h4>
<p><span aria-label="laughter tears" class="emoji emoji-1f602" role="img" title="laughter tears">:laughter_tears:</span>  sure, I can ask</p>



<a name="233339290"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339290" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339290">(Apr 06 2021 at 15:21)</a>:</h4>
<p>yeah</p>



<a name="233339308"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339308" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339308">(Apr 06 2021 at 15:22)</a>:</h4>
<p><span class="user-mention" data-user-id="217864">@matthiaskrgr</span> yeah also ask infra beforte you start worrying about CI time</p>



<a name="233339359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339359">(Apr 06 2021 at 15:22)</a>:</h4>
<p>my understanding is that rustc is on its own clock</p>



<a name="233339375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339375">(Apr 06 2021 at 15:22)</a>:</h4>
<p>there's some weird stuff there that i don't understand</p>



<a name="233339431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339431">(Apr 06 2021 at 15:22)</a>:</h4>
<p>Perfect. Than that should be all for today <span class="user-mention" data-user-id="261224">@triagebot</span> end-meeting (except someone else has something of course)</p>



<a name="233339433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339433">(Apr 06 2021 at 15:22)</a>:</h4>
<p>Does anyone have something to bring up?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if you're ready to end the meeting.</p>



<a name="233339443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339443">(Apr 06 2021 at 15:22)</a>:</h4>
<p>oh right,<br>
<a href="https://github.com/rust-lang-ci/">https://github.com/rust-lang-ci/</a></p>



<a name="233339444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339444">(Apr 06 2021 at 15:22)</a>:</h4>
<p>Do we than want to remove the current <code>lintcheck_crates_logs.txt</code> from the clippy repo and add it to the .gitignore?</p>



<a name="233339525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339525">(Apr 06 2021 at 15:23)</a>:</h4>
<p>Yeah, we don't really want those logs in the Clippy repo.</p>



<a name="233339605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339605">(Apr 06 2021 at 15:23)</a>:</h4>
<p>Mmh but it makes the diffing so much easier when writing lints <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="233339639"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339639" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339639">(Apr 06 2021 at 15:23)</a>:</h4>
<p>(before a lint is merged I mean)</p>



<a name="233339757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339757">(Apr 06 2021 at 15:24)</a>:</h4>
<p>Yes, but it has caused conflicts  for me in the past <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="233339923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233339923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233339923">(Apr 06 2021 at 15:25)</a>:</h4>
<p>Mmh, well for rebase you can just remove the log and rerun lintcheck.. :P<br>
But yeah if thats the only thing that causes the conflict I agree that that's annoying</p>



<a name="233340019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233340019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233340019">(Apr 06 2021 at 15:25)</a>:</h4>
<p>Maybe let the lintcheck tool download the previous log or something like that?</p>



<a name="233340128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233340128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233340128">(Apr 06 2021 at 15:26)</a>:</h4>
<p>Oh that's an interesting idea :)</p>



<a name="233340207"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233340207" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233340207">(Apr 06 2021 at 15:26)</a>:</h4>
<p>We can discuss this further offline.</p>
<p>Thanks for attending everyone <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="233340249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233340249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233340249">(Apr 06 2021 at 15:26)</a>:</h4>
<p>That would be neat solution :)</p>



<a name="233340299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233340299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233340299">(Apr 06 2021 at 15:27)</a>:</h4>
<p>so:</p>
<ul>
<li>move lintcheck repo to rust org</li>
<li>remove lintcheck log from clippy repo</li>
<li>download latest lintcheck log from the lintcheck</li>
</ul>



<a name="233340380"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233340380" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233340380">(Apr 06 2021 at 15:27)</a>:</h4>
<p>And add the log to the <code>.gitignore</code> file</p>



<a name="233340382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233340382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233340382">(Apr 06 2021 at 15:27)</a>:</h4>
<p>SGTM. But </p>
<ol start="0">
<li>ask infra about CI resources.</li>
</ol>



<a name="233344351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233344351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233344351">(Apr 06 2021 at 15:52)</a>:</h4>
<p>Woops, missed the meeting <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span> Just wanted to say that I'm back to working 8 hours/day after a year of reduced time due to corona affecting my employers business. In the meanwhile, my Rust has gotten a bit rusty.. To tackle that I want to try and focus more on writing new lints or features instead of only fixing bugs <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="233398665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233398665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233398665">(Apr 06 2021 at 22:09)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217864">matthiaskrgr</span> <a href="#narrow/stream/257328-clippy/topic/Meeting.202021-04-06/near/233335149">said</a>:</p>
<blockquote>
<p>not related to the sync but there is discussion about uplifting a clippy lint into rustc, I don't think the clippy team was pinged on that one yet?<br>
<a href="https://github.com/rust-lang/rust/issues/83899">https://github.com/rust-lang/rust/issues/83899</a></p>
</blockquote>
<p>there's also some discussion about uplifting <code>zero_ptr</code>: <a href="https://github.com/rust-lang/rust/issues/83856">https://github.com/rust-lang/rust/issues/83856</a></p>



<a name="233565273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-04-06/near/233565273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-04-06.html#233565273">(Apr 07 2021 at 21:20)</a>:</h4>
<p>err apparently that lint does something different, never mind</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>